-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to go v1.22 #3213
Update to go v1.22 #3213
Conversation
go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module github.com/operator-framework/operator-lifecycle-manager | |||
|
|||
go 1.21 | |||
go 1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting to see toolchain directive here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great call out! I didn't know about toolchains. Looking at the documentation, I think it says that if you don't specify a toolchain it will take tool chain for that version:
If the toolchain line is omitted, the module or workspace is considered to have an implicit toolchain goV line, where V is the Go version from the go line.
For example, a go.mod that says go 1.21.0 with no toolchain line is interpreted as if it had a toolchain go1.21.0 line.
Should we start updating the Go z-version and as well, do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know about implicit toolchain. I asked because I think go mod tidy
adds it by default.
I think explicit is better than implicit, but I think we can go ahead with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I'll make it explicit.
Signed-off-by: Per Goncalves da Silva <[email protected]>
68244a2
to
7d0fbf3
Compare
01d4a00
Description of the change:
Updates to go version 1.22
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue