clean-up: sets default architecture to amd64 #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Per Goncalves da Silva <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
perdasilva
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
itroyano
reviewed
May 6, 2024
| @@ -167,7 +167,7 @@ bin/e2e-local.test: FORCE test/e2e/assets/chart/zz_chart.go | |||
|
|
|||
| # set go env and other vars, ensure that the dockerfile exists, and then build wait, cpb, and other command binaries and finally the kind image archive | |||
| test/e2e-local.image.tar: export GOOS=linux | |||
| test/e2e-local.image.tar: export GOARCH=386 | |||
| test/e2e-local.image.tar: export GOARCH=amd64 | |||
There was a problem hiding this comment.
Hi @perdasilva any way to pass the attributes from the Makefile or set them as env vars so the e2e test doesn't need to hard-code their values?
There was a problem hiding this comment.
Hey, I'm going to refactor the Makefile soon. I'm just making small changes now to make sure CI goes through. It's very finicky sometimes...
kevinrizza
approved these changes
May 8, 2024
Merged
via the queue into
operator-framework:master
with commit May 8, 2024
b70e300
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Makes amd64 the default GOARCH for the binaries being built
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue