Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set securityContext values for extractContent containers #3270

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented May 21, 2024

Description of the change:
Make sure that the handling of the CatalogSource spec.grpcPodConfig.securityContextConfig applies when spec.grpcPodConfig.extractContent is defined

Motivation for the change:
Fixes a bug that causes extractContent-style catalogs to fail admission due to PSA restrictions, even when the CatalogSource is configured with spec.grpcPodConfig.securityContextConfig: restricted

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from stevekuznetsov and tmshort May 21, 2024 15:21
Copy link
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm nice!

@perdasilva perdasilva added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@tmshort tmshort added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@perdasilva perdasilva added this pull request to the merge queue May 22, 2024
Merged via the queue into operator-framework:master with commit 618aac7 May 22, 2024
12 checks passed
@joelanford joelanford deleted the extract-content-security-context branch October 30, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants