🌱 add copy-content to goreleaser and release artifacts #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Per Goncalves da Silva <[email protected]>
m1kola
reviewed
May 27, 2024
| @@ -7,6 +7,7 @@ RUN ["/busybox/ln", "-s", "/busybox/cp", "/bin/cp"] | |||
| COPY olm /bin/olm | |||
| COPY catalog /bin/catalog | |||
| COPY package-server /bin/package-server | |||
| COPY copy-content /bin/copy-content | |||
There was a problem hiding this comment.
Do I understand correctly - this is what ends up in the image we push to quay on release?
There was a problem hiding this comment.
That's right. We've been shipping without it =S
Downstream has been fine because we don't use this makefile or image for building/releasing
m1kola
approved these changes
May 27, 2024
Merged
via the queue into
operator-framework:master
with commit May 27, 2024
2334c05
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
I've noticed that
copy-contentis missing from the release artifacts. This PR adds it to goreleaser and the released imagesMotivation for the change:
copy-content is used for a particular mode of CatalogSource that uses the registry image only for its content (not using its opm server)
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue