Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 patch flakes #3281

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 27, 2024

Description of the change:

  • Bumps the sleep time in the operator unit test. I think leaving it at 1ms was starving the other processes leading to flakes
  • Updates a subscription e2e test to wait until the csv has changed before waiting for condition changes (the condition check passes for the old CSV as well - so the test flakes when we pass this condition check but the csv hasn't actually turned over yet

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Signed-off-by: Per Goncalves da Silva <[email protected]>
@openshift-ci openshift-ci bot requested review from joelanford and oceanc80 May 27, 2024 07:04
m1kola
m1kola previously approved these changes May 27, 2024
@perdasilva perdasilva enabled auto-merge May 27, 2024 07:59
@perdasilva perdasilva added this pull request to the merge queue May 27, 2024
Merged via the queue into operator-framework:master with commit 161b89c May 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants