Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 cleanup/tools #3285

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 27, 2024

Description of the change:
This PR moves tools that are orthogonal to OLM (e.g. kind, helm, golangci-lint, etc.) to .bingo. It only keeps certain necessary tools in tools.go

Motivation for the change:
Running into an issue where the helm version is skewing with our containerd version. So, the time has come to try to depollute the vendor directory.

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
@openshift-ci openshift-ci bot requested review from dtfranz and stevekuznetsov May 27, 2024 14:36
@perdasilva perdasilva force-pushed the clean/tools branch 3 times, most recently from 7378a56 to dcb23ba Compare May 27, 2024 14:50
@perdasilva perdasilva changed the title [WIP] 🌱 cleanup/tools 🌱 cleanup/tools May 27, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

@perdasilva perdasilva force-pushed the clean/tools branch 5 times, most recently from f10abcb to c5d7ed8 Compare May 28, 2024 11:03
Per Goncalves da Silva added 2 commits May 28, 2024 13:04
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva enabled auto-merge May 28, 2024 11:24
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@perdasilva perdasilva added this pull request to the merge queue May 28, 2024
Merged via the queue into operator-framework:master with commit 556637d May 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants