Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 patch installplan e2e #3301

Merged

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
This particular installplan e2e checks that updating to a package with fewer authorizations leads to an attenuated service account. Previously, the test would also check that the number secrets in the namespace wouldn't change. This PR removes that check because I don't think it is material to the test. What happens to the secrets (which I think are created by ocp?) isn't important. What is is that after the first csv is installed the SA is allowed to do something and after the upgrade it isn't.

Motivation for the change:
Reduce flakes and false negatives

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Signed-off-by: Per Goncalves da Silva <[email protected]>
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the mixing of Ginkgo and require, which was already in the base file... sigh...

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@tmshort tmshort enabled auto-merge May 31, 2024 13:35
@tmshort
Copy link
Contributor

tmshort commented May 31, 2024

/approve

@tmshort tmshort added this pull request to the merge queue May 31, 2024
Merged via the queue into operator-framework:master with commit a5230c7 May 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants