Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 patch subscription e2e flake #3302

Merged

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
This is a flaky test because the install plan conditions change to dynamically it would find itself checking the install plan conditions too early. This PR waits for the install plan pending condition to go away (to signal that the new install plan is being/has been applied), then wait for the bundle depracated condition to go away (in case its still stuck there from the previous state). This is what the test is really all about.

Motivation for the change:
Flaky behaviour

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Signed-off-by: Per Goncalves da Silva <[email protected]>
@openshift-ci openshift-ci bot requested review from awgreene and benluddy June 1, 2024 12:02
@perdasilva perdasilva merged commit 1404e91 into operator-framework:master Jun 1, 2024
12 checks passed
@perdasilva perdasilva deleted the perdasilva/patch-flake branch June 1, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant