Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/onsi/gomega from 1.33.1 to 1.34.1 #3354

Merged
merged 1 commit into from
Jul 30, 2024
Merged

build(deps): bump github.com/onsi/gomega from 1.33.1 to 1.34.1 #3354

merged 1 commit into from
Jul 30, 2024

Conversation

perdasilva
Copy link
Collaborator

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from anik120 and grokspawn July 30, 2024 16:33
@perdasilva
Copy link
Collaborator Author

Fixes #3351

@perdasilva perdasilva added the dependencies Pull requests that update a dependency file label Jul 30, 2024
dtfranz
dtfranz approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@dtfranz dtfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@perdasilva perdasilva added this pull request to the merge queue Jul 30, 2024
Merged via the queue into operator-framework:master with commit f1d9acd Jul 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtfranz dtfranz dtfranz approved these changes

@anik120 anik120 Awaiting requested review from anik120

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees

@dtfranz dtfranz

Labels
dependencies Pull requests that update a dependency file lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perdasilva @dtfranz