Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retract v3.11.0+incompatible #3355

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Aug 2, 2024

Copy link

openshift-ci bot commented Aug 2, 2024

Hi @janisz. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2024
@janisz
Copy link
Contributor Author

janisz commented Aug 2, 2024

cc: @porridge

@porridge
Copy link
Member

porridge commented Aug 5, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2024
Copy link
Member

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think this is better than having every user explicitly ignore this version.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
@janisz janisz changed the title Retract v.3.11.0 Retract v3.11.0+incompatible Aug 13, 2024
@kevinrizza
Copy link
Member

this looks reasonable to me. I just started the tests

Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
@perdasilva perdasilva enabled auto-merge August 13, 2024 15:03
@perdasilva perdasilva added this pull request to the merge queue Aug 13, 2024
Merged via the queue into operator-framework:master with commit 27f347e Aug 13, 2024
12 checks passed
@janisz janisz deleted the patch-1 branch August 14, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove broken git tag v3.11.0
5 participants