Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update owners #3361

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Update owners #3361

merged 1 commit into from
Aug 8, 2024

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Aug 8, 2024

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@anik120
Update owners
86a81e7 
Signed-off-by: Anik Bhattacharjee <[email protected]>
@openshift-ci openshift-ci bot requested review from oceanc80 and perdasilva August 8, 2024 14:25
anik120
anik120 commented Aug 8, 2024
View reviewed changes
Copy link
Contributor Author

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to add anyone else I'm missing

OWNERS
Comment on lines +9 to +11
- dtfranz
- anik120

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting @dtfranz and myself as approvers, to share the load with other reviewers. I realized we don't have a formal process set up to discuss this thing, if anyone disagrees please feel free to call it out here or reach out in private and I shall revert this change.

Also @dtfranz hope you're okay with this 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for doing that 😄

perdasilva
perdasilva approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@perdasilva perdasilva added this pull request to the merge queue Aug 8, 2024
@perdasilva
Copy link
Collaborator

Thank you, Anik!!! Well remembered =D

Merged via the queue into operator-framework:master with commit f9ee98e Aug 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtfranz dtfranz dtfranz left review comments

@perdasilva perdasilva perdasilva approved these changes

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@perdasilva perdasilva

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anik120 @perdasilva @dtfranz