Return an error when the IP status cannot be updated #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This status update function was not returning an error when an error occured, and could lead to a crash due returning nil for the IP. Signed-off-by: Todd Short <[email protected]>
acornett21
approved these changes
Oct 9, 2024
m1kola
approved these changes
Oct 10, 2024
| logger.Errorf("error updating InstallPlan status") | ||
| return nil, nil | ||
| logger.WithError(err).Error("error updating InstallPlan status") | ||
| return nil, fmt.Errorf("error updating InstallPlan status: %w", err) |
There was a problem hiding this comment.
Nit: I think the error should be opaque here: I do not see a reason for wrapping.
Merged
via the queue into
operator-framework:master
with commit Oct 10, 2024
a63b449
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This status update function was not returning an error when an error occured, and could lead to a crash due returning nil for the IP.
Description of the change:
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue