Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump golang.org/x/net to 0.34.0 #3485

Merged
merged 1 commit into from
Jan 10, 2025
Merged

bump golang.org/x/net to 0.34.0 #3485

merged 1 commit into from
Jan 10, 2025

Conversation

perdasilva
Copy link
Collaborator

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

bump golang.org/x/net to 0.34.0
f4480b9 
Signed-off-by: Per Goncalves da Silva <[email protected]>
camilamacedo86
camilamacedo86 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@perdasilva perdasilva enabled auto-merge January 10, 2025 10:08
gavinmbell
gavinmbell approved these changes Jan 10, 2025
View reviewed changes
Copy link

@gavinmbell gavinmbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
tumblr_0e00c6255ce86c0fff38d9b06e5a8aed_65f3941d_500

@perdasilva perdasilva added this pull request to the merge queue Jan 10, 2025
Merged via the queue into operator-framework:master with commit 6c8f9c3 Jan 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinmbell gavinmbell gavinmbell approved these changes

@thetechnick thetechnick thetechnick approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@gavinmbell gavinmbell

@camilamacedo86 camilamacedo86

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@perdasilva @gavinmbell @thetechnick @camilamacedo86