Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump o-f libs #3487

Merged
merged 3 commits into from
Jan 14, 2025
Merged

bump o-f libs #3487

merged 3 commits into from
Jan 14, 2025

Conversation

perdasilva
Copy link
Collaborator

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Sorry, something went wrong.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@perdasilva perdasilva marked this pull request as draft January 13, 2025 16:55
@openshift-ci openshift-ci bot requested review from anik120 and kevinrizza January 13, 2025 16:55
Per Goncalves da Silva added 3 commits January 14, 2025 18:34
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva marked this pull request as ready for review January 14, 2025 17:35
@openshift-ci openshift-ci bot requested a review from benluddy January 14, 2025 17:35
@perdasilva perdasilva changed the title [WIP] Bump/oflibs bump o-f libs Jan 14, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2025
@perdasilva perdasilva enabled auto-merge January 14, 2025 17:40
@camilamacedo86
Copy link
Contributor

@perdasilva should we not spplit it in 3 prs to make it easier to cherry-pick in downstream?

@perdasilva
Copy link
Collaborator Author

@perdasilva should we not spplit it in 3 prs to make it easier to cherry-pick in downstream?

@camilamacedo86 I think to downstream, we'll just specifically pick the x/net update commits. I don't think we want to bring down the go bump, k8s lib bump, etc.

@perdasilva perdasilva added this pull request to the merge queue Jan 14, 2025
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
Merged via the queue into operator-framework:master with commit 8b47a95 Jan 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants