Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for package migration/renaming #3547

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Mar 25, 2025

Description of the change:

Tests upgrades from one package to another within the same subscription. This is useful when renaming operator package.

No new features introduced: this is currently supported by OLM, but there are no tests for this.

Motivation for the change:

I'm currently working on migrating from one package name to another one and want to make sure this is supported by tests. From my experience this need arises from time to time: companies rename/rebrand their products and want pack names to match.

Architectural changes:

None

Testing remarks:

Adds tests

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Tests upgrades from one package to another within the same subscription.
This is useful when renaming operator package.

No new features introduced: this is currently supported by OLM,
but there are no tests for this.
Copy link

openshift-ci bot commented Mar 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@m1kola m1kola marked this pull request as ready for review March 25, 2025 18:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@openshift-ci openshift-ci bot requested review from dtfranz and oceanc80 March 25, 2025 18:53
@kevinrizza kevinrizza added this pull request to the merge queue Mar 25, 2025
Merged via the queue into operator-framework:master with commit 0a6499f Mar 25, 2025
12 checks passed
@m1kola m1kola deleted the test_upgrades_from_one_package_to_another branch March 25, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants