Skip to content

(plain bundle usage) Documentation on how to add a plain bundle image to a file-based catalog #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rashmigottipati
Copy link
Member

@rashmigottipati rashmigottipati commented Jul 18, 2023

Description of the change:
Write a plain bundle usage document by listing the process required to build a plain bundle image and add it to a file-based catalog.

Motivation for the change:
The goal of this document is to highlight steps to add a plain bundle image to a file-based catalog and enumerate the experimental olm.bundle.mediatype field. Currently,opm does not support plain bundles i.e. plain bundles cannot be rendered through opm render as the plain+v0 format is just the manifests and opm render would require the manifests and metadata in order to be able to render the plain bundle. This documentation provides instructions on how to manually include the plain bundle in a file-based catalog. Please note that this is experimental for now and not recommended for production usage.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Doc collaboration with @michaelryanpeter

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #1127 (2b4c7a8) into master (fa1b456) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
- Coverage   53.78%   53.77%   -0.01%     
==========================================
  Files         108      108              
  Lines       10163    10163              
==========================================
- Hits         5466     5465       -1     
- Misses       3736     3738       +2     
+ Partials      961      960       -1     

see 1 file with indirect coverage changes

@rashmigottipati rashmigottipati force-pushed the plain-bundle-usage-docs branch from 5b7d36a to 14b303a Compare July 18, 2023 16:25
@rashmigottipati rashmigottipati force-pushed the plain-bundle-usage-docs branch from 14b303a to 1027b4a Compare July 18, 2023 16:48
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! There are a few minor changes that need to be made. I've also left a few styling nits:

@rashmigottipati rashmigottipati force-pushed the plain-bundle-usage-docs branch 2 times, most recently from 317130f to 63e018c Compare July 18, 2023 21:48
@rashmigottipati rashmigottipati force-pushed the plain-bundle-usage-docs branch from 75e6f43 to b8afc77 Compare July 19, 2023 18:11

```sh
opm init <operator_name> \
--default-channel=preview \
Copy link
Member

@joelanford joelanford Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this flag required on the opm init command? If not, I'd suggest removing it because default channel is not an OLMv1 concept.

If it is required, should we consider an alternate instruction that has the user use HEREDOC to cat an olm.package directly into a file?

My motivation here is to avoid leaking OLMv0-specific APIs/concepts/behaviors into OLMv1 stuff.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. So, the flag itself is not required and I've removed it from the command. However, without the flag too, opm init generates an empty default channel in the index "defaultChannel": "".

I am guessing we should remove this line manually from the index. I think it should be ok for this doc to use the opm init and then explicitly mention about removing the empty default channel from the index file. Open to knowing about any other alternatives.

Copy link

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these comments address consistency usage. There are a couple of places where the instructions as written did not work for me, and I had to do something different. It could be because I used the Helm memcached-operator. But I am happy to sync to figure out what we need to change.

@rashmigottipati rashmigottipati force-pushed the plain-bundle-usage-docs branch from b8afc77 to 6069ac6 Compare July 24, 2023 20:03
Copy link

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few nits. Otherwise, LGTM!

…tices for channel naming conventions

Signed-off-by: Rashmi Gottipati <[email protected]>
@rashmigottipati rashmigottipati force-pushed the plain-bundle-usage-docs branch from 83cdaea to 2b4c7a8 Compare July 25, 2023 19:34
@michaelryanpeter
Copy link

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@michaelryanpeter: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@oceanc80
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, michaelryanpeter, oceanc80, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit bca2bfb into operator-framework:master Jul 25, 2023
@rashmigottipati rashmigottipati deleted the plain-bundle-usage-docs branch July 25, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants