Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bingo for managing tool deps #1394

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Jul 30, 2024

Description of the change:
#1329 resuscitated

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from benluddy and njhale July 30, 2024 14:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.14%. Comparing base (4c943fa) to head (8f3b737).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1394   +/-   ##
=======================================
  Coverage   48.14%   48.14%           
=======================================
  Files         134      134           
  Lines       12752    12752           
=======================================
  Hits         6139     6139           
  Misses       5575     5575           
  Partials     1038     1038           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix for the windows goreleaser stuff! Thanks!

Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [joelanford,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva perdasilva force-pushed the bingo branch 3 times, most recently from 01a25bb to be48470 Compare August 7, 2024 13:18
Signed-off-by: Per Goncalves da Silva <[email protected]>
@tmshort
Copy link
Contributor

tmshort commented Aug 7, 2024

protoc is not a go binary, but you have bingo artifacts for it?

@joelanford
Copy link
Member

@tmshort protoc-gen-go is a go binary. protoc is not.

@joelanford joelanford added this pull request to the merge queue Aug 7, 2024
Merged via the queue into operator-framework:master with commit 5d090ba Aug 7, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants