remove 'automatically generated' strings from repo #1412
Conversation
Maintainers use an import organizer called 'gci' that ignores files with the string 'automatically generated' when called with its --skip-generated flag. This commit is the result of the following command: ``` rg ' automatically generated' -l | xargs -n1 sed -i 's/ automatically generated//g' ``` None of the changed files are _actually_ generated files. We do not want gci to think they are. Signed-off-by: Joe Lanford <[email protected]>
openshift-ci
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
=======================================
Coverage 48.14% 48.14%
=======================================
Files 134 134
Lines 12752 12752
=======================================
Hits 6139 6139
Misses 5575 5575
Partials 1038 1038 ☔ View full report in Codecov by Sentry. |
joelanford
removed
the
approved
| @@ -17,7 +17,7 @@ spec: | |||
|
|
|||
| ### Reading and writing to etcd | |||
|
|
|||
| Communicate with etcd though its command line utility `etcdctl` or with the API using the automatically generated Kubernetes Service. | |||
There was a problem hiding this comment.
Is there any cause for concern that these diverge from the source?
There was a problem hiding this comment.
I don't think so, all just one-time copied test files.
There was a problem hiding this comment.
Also :whistles: .... the etcd content is duplicated all over this repo.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
b12dea8
Maintainers use an import organizer called 'gci' that ignores files with the string 'automatically generated' when called with its --skip-generated flag.
This commit is the result of the following command:
None of the changed files are actually generated files. We do not want gci to think they are.
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs