Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert go bump and redo #1531

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

perdasilva
Copy link
Contributor

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Per Goncalves da Silva and others added 4 commits January 10, 2025 16:05
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@camilamacedo86
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Jan 10, 2025
@grokspawn
Copy link
Contributor

apidiff failing because it is reverting the api-breaking changes from the original PR. This PR restores the API.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 46.75%. Comparing base (086a83b) to head (8330b18).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/api/registry_grpc.pb.go 0.00% 70 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
- Coverage   46.82%   46.75%   -0.08%     
==========================================
  Files         135      135              
  Lines       15754    15776      +22     
==========================================
- Hits         7377     7376       -1     
- Misses       7336     7359      +23     
  Partials     1041     1041              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into operator-framework:master with commit a4f9b6b Jan 10, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants