-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 synch dockerfiles with grpc-health-probe version in go.mod #1577
🌱 synch dockerfiles with grpc-health-probe version in go.mod #1577
Conversation
Signed-off-by: Jordan Keister <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
+ Coverage 46.76% 46.77% +0.01%
==========================================
Files 135 135
Lines 15776 15883 +107
==========================================
+ Hits 7377 7429 +52
- Misses 7358 7413 +55
Partials 1041 1041 ☔ View full report in Codecov by Sentry. |
registry.Dockerfile
Outdated
@@ -5,7 +5,7 @@ WORKDIR /build | |||
|
|||
COPY . . | |||
RUN make static | |||
RUN GRPC_HEALTH_PROBE_VERSION=v0.4.28 && \ | |||
RUN GRPC_HEALTH_PROBE_VERSION=v0.4.37 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we maybe do something like
RUN GRPC_HEALTH_PROBE_VERSION=v0.4.37 && \ | |
RUN GRPC_HEALTH_PROBE_VERSION=$(go list -m github.com/grpc-ecosystem/grpc-health-probe | cut -d " " -f2) && \ |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and we should fix the FROM/AS case parity on line 1, i.e. FROM golang:1.23-alpine AS builder
release/goreleaser.opm.Dockerfile
Outdated
@@ -2,7 +2,7 @@ | |||
# build opm images. See the configurations in .goreleaser.yaml | |||
# and .github/workflows/release.yaml. | |||
|
|||
FROM ghcr.io/grpc-ecosystem/grpc-health-probe:v0.4.29 as grpc_health_probe | |||
FROM ghcr.io/grpc-ecosystem/grpc-health-probe:v0.4.37 as grpc_health_probe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FROM ghcr.io/grpc-ecosystem/grpc-health-probe:v0.4.37 as grpc_health_probe | |
FROM ghcr.io/grpc-ecosystem/grpc-health-probe:v0.4.37 AS grpc_health_probe |
upstream-builder.Dockerfile
Outdated
@@ -5,7 +5,7 @@ WORKDIR /build | |||
|
|||
COPY . . | |||
RUN make static | |||
RUN GRPC_HEALTH_PROBE_VERSION=v0.4.28 && \ | |||
RUN GRPC_HEALTH_PROBE_VERSION=v0.4.37 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix the FROM/AS case parity in this one too
i.e. line 1 goes to FROM golang:1.23-alpine AS builder
Signed-off-by: Jordan Keister <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
57fd364
Resolves #1561
This sets the grpc-health-probe version used in all project Dockerfiles to use the same version as the go.mod.
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs