Skip to content
This repository was archived by the owner on Nov 18, 2020. It is now read-only.

[WIP] webhook example for memcached #63

Closed

Conversation

theishshah
Copy link
Member

Built using controller-runtime v2alpha

Contains 2 webhooks, one to mutate new pods with a sample annotation and a validator to check that the mutation occurred.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 26, 2019
@theishshah
Copy link
Member Author

(High LoC change count due to new version of dependencies)
Actual changes were made to cmd/manager/ for webhooks, various minor fixes around the codebase to support the new versions of controller-runtime

@camilamacedo86
Copy link
Contributor

Hi @theishshah,

It shows very outdated. Is it something that should we move forward with? If yes, could you please rebase for we are able to review?

@camilamacedo86
Copy link
Contributor

Hi @theishshah,

I am closing this one because shows very outdated and is open for too long without changes. However, feel free to re-open if you wish still working on this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants