Skip to content

vendor: add vendor #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Conversation

AlexNPavel
Copy link
Contributor

Description of the change: Add vendor to git

Motivation for the change: Dep is slow and unreliable on travis. To fix this, we can include vendor in our git repo, which many other projects do as well. Our vendor folder is only about 60MB.

Related to Issue #1062 and PR #1063.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 5, 2019
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@AlexNPavel AlexNPavel merged commit 408edf4 into operator-framework:master Feb 6, 2019
@AlexNPavel AlexNPavel deleted the vendor branch February 6, 2019 18:18
@AlexNPavel AlexNPavel mentioned this pull request Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants