Skip to content

CHANGELOG.md: new --header-file flag for 'add api' and 'generate k8s' #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2019
Merged

CHANGELOG.md: new --header-file flag for 'add api' and 'generate k8s' #1257

merged 3 commits into from
Apr 1, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Mar 27, 2019

From #1239

@estroz estroz added the docs label Mar 27, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2019
@hasbro17
Copy link
Contributor

Can we update the CHANGELOG and CLI docs to point out that this flag is optional? Right now it seems as if it's not.

joelanford
joelanford approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit 5e727c6 into operator-framework:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@theishshah theishshah Awaiting requested review from theishshah

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estroz @hasbro17 @joelanford @openshift-ci-robot