Skip to content

Makefile: Run unit tests in internal dir #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2019
Merged

Makefile: Run unit tests in internal dir #1269

merged 2 commits into from
Apr 1, 2019

Conversation

lilic
Copy link
Member

@lilic lilic commented Apr 1, 2019

Description of the change:
Since we moved some dirs under the internal dir we need to adjust the
unit make target so those tests run in CI.

@lilic
Makefile: Run unit tests in internal dir
a0521ca 
Since we moved some dirs under the internal dir we need to adjust the
unit make target so those tests run in CI.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2019
joelanford
joelanford approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks! LGTM

estroz
estroz approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2019
hasbro17
hasbro17 approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit 83f710b into operator-framework:master Apr 1, 2019
@lilic lilic deleted the lili/internal-unit branch April 2, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@estroz estroz estroz approved these changes

Assignees

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lilic @joelanford @hasbro17 @estroz @openshift-ci-robot