-
Notifications
You must be signed in to change notification settings - Fork 1.8k
doc/user/migrating-existing-apis.md: document API version migra… #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @estroz, a few nits but non-blocking.
Kubernetes APIs are assumed to evolve over time, hence the well-defined API [versioning scheme][k8s-versioning]. Upgrading your operator's APIs can be a non-trivial task, one that will involve changing quite a few source files and manifests. This document aims to identify the complexities of migrating an operator project's API using examples from existing operators. | ||
|
||
While examples in this guide follow particular types of API migrations, most of the documented migration steps can be generalized to all migration types. A thorough discussion of migration types for a particular project type (Go, Ansible, Helm) is found at the end of each project type's section. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be beneficial to start with a happy case where the GVK
contains a single kind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean do a walkthrough of a migration with a single kind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - the first case is a bit more difficult to consume when compared to the case outlined here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case should be added in a follow-up PR since there are a lot of changes here already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
9f21ac8
to
2ae7e53
Compare
…wing kubernetes API conventions
…ge conversion wording
2ae7e53
to
faa1efa
Compare
/test e2e-aws-subcommand |
Sorry for the hold up. I'll finish my review on this hopefully in a day or so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some edits to the CRD manifest naming format but other than that LGTM.
Co-Authored-By: Haseeb Tariq <[email protected]>
New changes are detected. LGTM label has been removed. |
/test e2e-aws-go |
/test e2e-aws-ansible |
1 similar comment
/test e2e-aws-ansible |
Description of the change: From #1541:
Note: for Go projects only. Ansible and Helm have TODO's.
Motivation for the change: see #1541.
Closes #1541
PTAL @awgreene @dmesser