test/: clean up some e2e setup code #4315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
|
||
| By("cleaning up permissions") | ||
| _, _ = tc.Kubectl.Command("delete", "clusterrolebinding", | ||
| metricsClusterRoleBindingName) |
There was a problem hiding this comment.
the reason. for the break in the lines is for not be required to scroll to check the code.
There was a problem hiding this comment.
I think these lines I changed should still be < 120 chars wide.
|
|
||
| By("deploying project on the cluster") | ||
| err := tc.Make("deploy", "IMG="+tc.ImageName) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(tc.Make("deploy", "IMG="+tc.ImageName)).To(Succeed()) |
| // WrapWarn is a one-liner to wrap an error from a command that returns (error) in a warning. | ||
| func WrapWarn(err error) { | ||
| WrapWarnOutput("", err) | ||
| } |
There was a problem hiding this comment.
WDYT. about push it to upstream?
camilamacedo86
approved these changes
Dec 15, 2020
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
Signed-off-by: reinvantveer <[email protected]>
rearl-scwx
pushed a commit
to rearl-scwx/operator-sdk
that referenced
this pull request
Feb 5, 2021
Signed-off-by: rearl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: clean up some e2e setup code
Motivation for the change: fix some potential panics and warn on error instead of not checking error at all
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs