-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added quarkus/v1-alpha plugin #4871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added quarkus/v1-alpha plugin #4871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is missing:
- changelog (fragment)
- sample in the testdata with the java plugin such as it has for go/helm/ansible
-e2e tests such as it has for go/helm/ansible
Note that is not passing in the sanity because you need to run make generate to re-gen docs.
@camilamacedo86 the samples live in the plugins repo: https://github.com/operator-framework/java-operator-plugins/tree/main/testdata/memcached-quarkus-operator and it is a v1alpha so it will likely go through massive changes |
Agreed, samples do not need to live in the operator-sdk repo if the plugin is external. Still needs a changelog, and make sure to specify that this plugin is alpha and subject to breaking changes. |
How will we ensure that SDK is generating that properly? So, I think we need a sample in the SDK repo. Also, how we will check its default result and compare the changes and etc? Note that check the samples scaffold is very helpful in the review and development process as we are able to share an example with the users as well. Also, should we not ensure that the java plugin generated with SDK also pass in the e2e tests such as is deployed, scorecard, bundle tests and etc? |
Because operator-sdk calls the plugin directly from its repo, which should be creating sample code itself. I do not want one sample per external plugin, as Operator SDK does not necessarily own nor maintain those plugins. That just isn't scalable.
We can add integration tests for these, but a checked-in sample is not a requirement for integration tests. These tests can be added in a follow-up since the plugin is very much alpha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laxmikantbpandhare you may have to run make generate
to generate the samples again after the change.
Yes, I already did and then only did commit. But, sanity is still failing. I will try once again. |
Added changelog (fragment) |
I rebased your commit onto master locally, ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
New changes are detected. LGTM label has been removed. |
Signed-off-by: laxmikantbpandhare <[email protected]>
made java to quarkus made v1 to v1alpha made v1 to v1alpha Signed-off-by: laxmikantbpandhare <[email protected]> made v1 to v1alpha Signed-off-by: laxmikantbpandhare <[email protected]> after make generate command mod file kubebuilder version changes added changelog Signed-off-by: laxmikantbpandhare <[email protected]> modified test-sanity Signed-off-by: laxmikantbpandhare <[email protected]> testdata Signed-off-by: laxmikantbpandhare <[email protected]> did make generate
Signed-off-by: Eric Stroczynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
This change will enable the command for Java Plugin.
Motivation for the change:
Implementation of Java Operator's in Operator Framework.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs