Skip to content

bump java plugins #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

bump java plugins #4940

merged 1 commit into from
May 25, 2021

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented May 24, 2021

Description of the change:
Bump the java plugin so that it picks up the recent Makefile changes.

Motivation for the change:
The java plugin now has a Makefile which we'd like to include in the first release of the plugin with the SDK.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested review from fabianvf and theishshah May 24, 2021 13:07
@jmrodri jmrodri requested review from estroz and laxmikantbpandhare and removed request for fabianvf and theishshah May 24, 2021 13:07
@jmrodri
Copy link
Member Author

jmrodri commented May 24, 2021 

[jesusr@transam java-op]$ ls
[jesusr@transam java-op]$ operator-sdk init --plugins quarkus  --domain zeusville.com --project-name java-op
[jesusr@transam java-op]$ ls
Makefile  pom.xml  PROJECT  src/

@jmrodri jmrodri force-pushed the bump-java-plugin branch from 7301d01 to 5f213b6 Compare May 24, 2021 13:09
@jmrodri
bump java plugins
433faa5 
Signed-off-by: jesus m. rodriguez <[email protected]>
@jmrodri jmrodri force-pushed the bump-java-plugin branch from 5f213b6 to 433faa5 Compare May 24, 2021 14:14
rashmigottipati
rashmigottipati approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2021
laxmikantbpandhare
laxmikantbpandhare approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

estroz
estroz approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri merged commit 2ddde63 into operator-framework:master May 25, 2021
@jmrodri jmrodri deleted the bump-java-plugin branch May 25, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@estroz estroz estroz approved these changes

@laxmikantbpandhare laxmikantbpandhare laxmikantbpandhare approved these changes

Assignees

@rashmigottipati rashmigottipati

@estroz estroz

@laxmikantbpandhare laxmikantbpandhare

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmrodri @rashmigottipati @estroz @laxmikantbpandhare