Skip to content

Bug 2090135: Propagate correct error message for an invalid index #5893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rashmigottipati
Copy link
Member

Description of the change:
Propagate correct error message when an invalid index image is provider by the user that does not exist.

Motivation for the change:
With this fix, the error below would be as below:

▶ ./build/operator-sdk run bundle quay.io/olmqe/k8sstatus-bundle:v4.10 --index-image quay.io/kakatest/kkkkk:test
FATA[0005] Failed to run bundle: error determining whether index "quay.io/kakatest/kkkkk:test" is FBC or SQLite based: get index image labels: error pulling image quay.io/kakatest/kkkkk:test: error resolving name : unexpected status code [manifests test]: 401 UNAUTHORIZED

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested review from joelanford and marc-obrien June 22, 2022 17:14
@rashmigottipati rashmigottipati requested review from jmrodri, everettraven and joelanford and removed request for joelanford and marc-obrien June 22, 2022 17:14
@rashmigottipati rashmigottipati changed the title Bug 2090135: Handle error message appropriately for an invalid index Bug 2090135: Propagate correct error message for an invalid index Jun 22, 2022
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
@rashmigottipati rashmigottipati merged commit 34f6b42 into operator-framework:master Jun 22, 2022
@rashmigottipati rashmigottipati deleted the fix-error-messages branch June 22, 2022 18:32
@everettraven
Copy link
Contributor

/cherry-pick v1.22.x

@openshift-cherrypick-robot

@everettraven: new pull request created: #5919

In response to this:

/cherry-pick v1.22.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants