Skip to content

chore(contrib): Add PR template and commit message guidelines. #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2018
Merged

chore(contrib): Add PR template and commit message guidelines. #231

merged 3 commits into from
Nov 7, 2018

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Nov 6, 2018

No description provided.

@coveralls
Copy link

coveralls commented Nov 6, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.677%
Totals Coverage Status
Change from base Build 741: 0.0%
Covered Lines: 2647
Relevant Lines: 2985
💛 - Coveralls

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit e8286be into master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @coveralls @thomaszurkan-optimizely