Skip to content

(fix): use a ParserSupplier instead of java.util.Supplier to enable work on older versions of Android. #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2019
Merged

(fix): use a ParserSupplier instead of java.util.Supplier to enable work on older versions of Android. #340

merged 2 commits into from
Oct 11, 2019

Conversation

thomaszurkan-optimizely
Copy link
Contributor

Summary

  • This has been tested on all supported versions and it works now. We will also need to release 3.3.1 to patch this for Android.

Test plan

Tested on Android. It will also work on travis after this fix. Travis builds won't pass with 3.3.0

Issues

Android versions < API 24 can't use java.util.Supplier. This replaces Supplier with a local ParserSupplier which allows it to work on all versions of Android.

@thomaszurkan-optimizely thomaszurkan-optimizely requested a review from a team as a code owner October 11, 2019 00:03
@coveralls
Copy link

coveralls commented Oct 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1220

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.818%
Totals Coverage Status
Change from base Build 1213: 0.0%
Covered Lines: 25256
Relevant Lines: 28119
💛 - Coveralls

mikeproeng37
mikeproeng37 approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

mikecdavis
mikecdavis approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 37bd3c6 into master Oct 11, 2019
thomaszurkan-optimizely added a commit that referenced this pull request Oct 11, 2019
@thomaszurkan-optimizely
(fix): use a ParserSupplier instead of java.util.Supplier to enable w…
ffcd14f 
…ork on older versions of Android. (#340)

* use a ParserSupplier to enable work on older versions of Android.

* remove the generics
thomaszurkan-optimizely added a commit that referenced this pull request Oct 11, 2019
@thomaszurkan-optimizely
(chore): chrerry pick changes to 3.3.x. (#342)
38d6606 
* (fix): use a ParserSupplier instead of java.util.Supplier to enable work on older versions of Android. (#340)

* use a ParserSupplier to enable work on older versions of Android.

* remove the generics

* update for new release for android support (#341)
@mikecdavis mikecdavis deleted the removeJavaUtilSupplier branch October 12, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@mikecdavis mikecdavis mikecdavis approved these changes

Assignees

@thomaszurkan-optimizely thomaszurkan-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomaszurkan-optimizely @coveralls @mikeproeng37 @mikecdavis