Skip to content

feat: added enabled field in metadata. #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2020
Merged

feat: added enabled field in metadata. #409

merged 2 commits into from
Nov 13, 2020

Conversation

mnoman09
Copy link
Contributor

Summary

  • While sending impression events, metadata should have enabled field as well.

Test plan

  • updated unit tests
  • FSC should pass

@mnoman09 mnoman09 requested a review from a team as a code owner November 10, 2020 15:56
@coveralls
Copy link

coveralls commented Nov 10, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1594

  • 11 of 11 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.75%
Totals Coverage Status
Change from base Build 1583: 0.02%
Covered Lines: 4133
Relevant Lines: 4605
💛 - Coveralls

jaeopt
jaeopt requested changes Nov 10, 2020
View reviewed changes
core-api/src/main/java/com/optimizely/ab/event/internal/payload/DecisionMetadata.java
this.flagKey = flagKey;
this.ruleKey = ruleKey;
this.ruleType = ruleType;
this.variationKey = variationKey;
this.enabled = enabled;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add "getEnabled()"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we add it if it's not used?

jaeopt
jaeopt approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt closed this Nov 12, 2020
@jaeopt jaeopt reopened this Nov 12, 2020
@jaeopt jaeopt closed this Nov 12, 2020
@jaeopt jaeopt reopened this Nov 12, 2020
@jaeopt jaeopt merged commit b551357 into master Nov 13, 2020
@jaeopt jaeopt deleted the mnoman/fd_patch branch November 13, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnoman09 @coveralls @pawels-optimizely @jaeopt