Skip to content

feat: Converted index.react_native.js to TS #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 49 commits into from
Closed

feat: Converted index.react_native.js to TS #583

wants to merge 49 commits into from

Conversation

ozayr-zaviar
Copy link
Contributor

Summary

  • Converted packages\optimizely-sdk\lib\index.react_native.js to TS

Test plan

  • All existing unit tests should pass
  • All existing test cases on FSC should pass

uzair-folio3 and others added 22 commits September 28, 2020 12:41
@yavorona
added declaration file for notification center
bc99e5d
@yavorona
comment addressed: seperate declaration file for event_helper event_h…
5819fff 
…elper.d.ts
@yavorona
event_helpers module name and declaration file name corrected
a27a13c
@yavorona
EOL in event_helpers.d.ts
6cc5495
@yavorona
Convert Optimizely Module
687d620
@yavorona
Fix comments
0df41cf
@yavorona
Update formatting and add optional attribute sign
a2cefd7
@yavorona
Clean up
a86dc34
@yavorona
Address Matt's comments part 1
343518e
@yavorona
Address comment part2
b34d864
@yavorona
Incorporating commenta part 3
04b44cc
@yavorona
Incorporate comments part 4
90cd51c
@yavorona
Updating names of private methods
e8473a5
@yavorona
Update private methods
32faf70
@yavorona
Create configObj interface
289f2ea
@yavorona
Clean up
3b0ba96
@yavorona
Add back DatafileOptions
096f857
@yavorona
Create ProjectConfigManagerConfig interface
625da66
@yavorona
Fix LogTierV1EventProcessor compiler error without re-defining LogTie…
b76d534 
…rV1EventProcessorConfig
@yavorona
Fix EventTags to not except boolean
145838b
@yavorona
incporporating comments part 1
510bb95
converted intex.react_native.js to ts according to optimizely module
cb7a600
@ozayr-zaviar ozayr-zaviar removed their assignment Oct 2, 2020
@ozayr-zaviar
Copy link
Contributor Author

This PR is based on optimizely_module. This PR contains some issues due to parent PR. Need to rebase it once optimizely_module is merged.

yavorona and others added 21 commits October 2, 2020 12:42
@yavorona
Fix comments
080198d
@yavorona
Update formatting and add optional attribute sign
58978f1
@yavorona
Clean up
07dc378
@yavorona
Address Matt's comments part 1
1faf4ea
@yavorona
Address comment part2
dd8d1f4
@yavorona
Incorporating commenta part 3
dfc96df
@yavorona
Incorporate comments part 4
9a23b65
@yavorona
Updating names of private methods
166ca11
@yavorona
Update private methods
f75acb7
@yavorona
Create configObj interface
2005324
@yavorona
Clean up
0f1dc9a
@yavorona
Add back DatafileOptions
b3be1c9
@yavorona
Create ProjectConfigManagerConfig interface
6e53691
@yavorona
Fix LogTierV1EventProcessor compiler error without re-defining LogTie…
8e6ec59 
…rV1EventProcessorConfig
@yavorona
Fix EventTags to not except boolean
440d009
@yavorona
incporporating comments part 1
90b133b
@yavorona
Incoprorate comments part 2
7de389e
@yavorona
Returned UserAttributes type back go index.d.ts
63b7882
@yavorona
Return all types back to index.d.ts
8da7267
Merge branch 'pnguen/optimizely-module-to-ts' into uzair/react_native…
979dadb 
…_js_to_ts
copied optimizelyconfig from optimizely module to sharedType
a7f6a86
@coveralls
Copy link

coveralls commented Oct 5, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 96.597% when pulling c064839 on uzair/react_native_js_to_ts into 4e790fd on master.

@raju-opti raju-opti deleted the uzair/react_native_js_to_ts branch October 4, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ozayr-zaviar @coveralls @yavorona