Skip to content

fix(project config manager): Don't log an error when not initialized with datafile #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2020
Merged

fix(project config manager): Don't log an error when not initialized with datafile #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c5a531
fix(project config manager): Don't log an error when not initialized …
Oct 5, 2020
fb7dcf6
Merge branch 'master' into mcarroll/fix-error-when-not-initialized-wi…
Oct 6, 2020
8ffd5d9
Add changelog entry
Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/optimizely-sdk/CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Bug fixes

- Fixed return type of `getAllFeatureVariables` method and `dispatchEvent ` method signature of `EventDispatcher` interface in TypeScript type definitions ([#576](https://github.com/optimizely/javascript-sdk/pull/576))
- Don't log an error message when initialized with `sdkKey`, but no `datafile` ([#589](https://github.com/optimizely/javascript-sdk/pull/589))

## [4.3.1] - October 5, 2020

Expand Down
9 changes: 7 additions & 2 deletions packages/optimizely-sdk/lib/core/project_config/project_config_manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,13 @@ ProjectConfigManager.prototype.__initialize = function(config) {
return;
}

var handleNewDatafileException = this.__handleNewDatafile(config.datafile);
if (handleNewDatafileException) {
let handleNewDatafileException;
if (config.datafile) {
handleNewDatafileException = this.__handleNewDatafile(config.datafile);
if (handleNewDatafileException) {
this.__configObj = null;
}
} else {
this.__configObj = null;
}

Expand Down
7 changes: 7 additions & 0 deletions packages/optimizely-sdk/lib/core/project_config/project_config_manager.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,13 @@ describe('lib/core/project_config/project_config_manager', function() {
manager.stop();
sinon.assert.calledOnce(datafileManager.HttpPollingDatafileManager.getCall(0).returnValue.stop);
});

it('does not log an error message', function() {
projectConfigManager.createProjectConfigManager({
sdkKey: '12345',
});
sinon.assert.notCalled(stubLogHandler.log);
});
});

describe('when constructed with sdkKey and with a valid datafile object', function() {
Expand Down