Skip to content

feat: Add enabled to decision metadata #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2020

Conversation

yavorona
Copy link
Contributor

Summary

  • Added enabled field to decision metadata structure
  • Set enabled to true in activate() and to featureEnabled value in isFeatureEnable()

Note

This pr will be finalized after #618 is merged and event-processor package is released

Test plan

Unit tests

Issues

OASIS-7347

@yavorona yavorona requested a review from a team as a code owner November 10, 2020 06:17
@yavorona yavorona removed their assignment Nov 10, 2020
@yavorona yavorona changed the title feat: Add enabled to metadata feat: Add enabled to decision metadata Nov 10, 2020
@coveralls
Copy link

coveralls commented Nov 10, 2020

Coverage Status

Coverage increased (+0.0004%) to 96.707% when pulling ddbd719 on pnguen/add-enabled-to-metadata into 1fb0013 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 96.707% when pulling b4e11a8 on pnguen/add-enabled-to-metadata into e0158e5 on master.

Copy link
Contributor

@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a CHANGELOG entry.

@yavorona yavorona force-pushed the pnguen/add-enabled-to-metadata branch from d721ac8 to d002790 Compare November 10, 2020 21:57

Verified

This commit was signed with the committer’s verified signature.
mcous Michael Cousins

Verified

This commit was signed with the committer’s verified signature.
mcous Michael Cousins
@yavorona yavorona force-pushed the pnguen/add-enabled-to-metadata branch from 23916a2 to ddbd719 Compare November 12, 2020 18:48
@yavorona yavorona closed this Nov 13, 2020
@yavorona yavorona reopened this Nov 13, 2020
@yavorona yavorona merged commit 170ab61 into master Nov 13, 2020
@yavorona yavorona deleted the pnguen/add-enabled-to-metadata branch November 13, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants