[FSSDK-8651] added support for user agent parser for odp #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikechu-optimizely
approved these changes
Aug 21, 2023
jaeopt
reviewed
Aug 21, 2023
|
|
||
| import { UserAgentInfo } from "./user_agent_info"; | ||
|
|
||
| export interface IUserAgentParser { |
There was a problem hiding this comment.
Wondering if we care much about this parser. What about let them inject userAgentInfo as an object or make it more general as "clientOdpInfo" letting them add beyond the user-agent info?
There was a problem hiding this comment.
Yeah, we can rename the interface and add a general map<string, unknown> in the UserAgentInfo type.
There was a problem hiding this comment.
A question is while we can make it flexible, we may want to pre-define a few "required" names like os-name, os-version, device-model, ... to be consistent with other SDKs. @raju-opti
There was a problem hiding this comment.
Yeah. UserAgentInfo type already has os and device fields. We can add a few more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues