Skip to content

fix(track): Send decisions for all experiments using an event when using track #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2018
Merged

fix(track): Send decisions for all experiments using an event when using track #124

merged 1 commit into from
Aug 27, 2018

Conversation

msohailhussain
Copy link
Contributor

Note: Sending one more PR on php-testapp, getting failed on FS track mng/add-test-for-multiple-events

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 97.09% when pulling 86ca673 on sohail/multiexperimentenvfix into 548594a on master.

@msohailhussain msohailhussain requested a review from oakbani August 23, 2018 20:08
@mikeproeng37
Copy link
Contributor

build

oakbani
oakbani reviewed Aug 27, 2018
View reviewed changes
Copy link
Contributor

@oakbani oakbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mikeproeng37
Copy link
Contributor

build

2 similar comments
@msohailhussain
Copy link
Contributor Author

build

@mikeproeng37
Copy link
Contributor

build

mikeproeng37
mikeproeng37 approved these changes Aug 27, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit fbf5499 into master Aug 27, 2018
@oakbani oakbani deleted the sohail/multiexperimentenvfix branch August 28, 2018 04:40
mikeproeng37 pushed a commit that referenced this pull request Oct 29, 2018
@msohailhussain
fix(track): Send decisions for all experiments using an event when us…
13c476d 
…ing track (#124)
mikeproeng37 pushed a commit that referenced this pull request Oct 29, 2018
@msohailhussain
fix(track): Send decisions for all experiments using an event when us…
9b01b96 
…ing track (#124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oakbani oakbani oakbani left review comments

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msohailhussain @coveralls @mikeproeng37 @oakbani