fix(datafile-parsing): Prevent newer versions datafile #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
suggested changes
Sep 4, 2018
src/Optimizely/Optimizely.php
Outdated
| @@ -127,12 +128,13 @@ public function __construct( | |||
|
|
|||
| try { | |||
| $this->_config = new ProjectConfig($datafile, $this->_logger, $this->_errorHandler); | |||
| } catch (Throwable $exception) { | |||
| } catch (InvalidDatafileVersionException $e) { | |||
There was a problem hiding this comment.
Same as Python PR, please consolidate these two cases into one.
And pass the exception to the errorHandler
tests/OptimizelyTest.php
Outdated
| public function testInitUnSupportedDatafileVersion() | ||
| { | ||
| $datafile = json_decode($this->datafile, true); | ||
| $datafile['version'] = '5'; |
There was a problem hiding this comment.
Instead of doing this, let's create a small unsupported_datafile that has one running experiment in it and use that here.
aliabbasrizvi
approved these changes
Sep 6, 2018
src/Optimizely/ProjectConfig.php
Outdated
| @@ -196,6 +200,13 @@ public function __construct($datafile, $logger, $errorHandler) | |||
| $this->_revision = $config['revision']; | |||
| $this->_forcedVariationMap = []; | |||
|
|
|||
| $supportedVersions = array(self::V2, self::V3, self::V4); | |||
There was a problem hiding this comment.
I'd recommend setting this up at the top of this method. It is extremely hard to read it here.
|
build |
mikeproeng37
pushed a commit
that referenced
this pull request
Oct 29, 2018
mikeproeng37
pushed a commit
that referenced
this pull request
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.