fix(generateBucketValue): Avoid negative bucket number for PHP x86 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $bucketVal = intval(floor($ratio * Bucketer::$MAX_TRAFFIC_VALUE)); | ||
|
|
||
| if ($bucketVal < 0) { | ||
| $bucketVal += 10000; |
There was a problem hiding this comment.
nit. Add comment here as to why we are doing this.
aliabbasrizvi
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
on x86, when 32 bit hash code is generated, it overflows and fall into float type which causes the number into negative and beyond out of range.
The "why", or other context.
Test plan
Issues