Skip to content

feat(api): Feature variable APIs return default variable value when featureEnabled property is false. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2019
Merged

feat(api): Feature variable APIs return default variable value when featureEnabled property is false. #159

merged 2 commits into from
Apr 1, 2019

Conversation

rashidsp
Copy link
Contributor

Summary

  • Feature variable APIs now return default variable value when featureEnabled property is false.

Test plan

  • Added unit tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 98.118% when pulling 54e918d on rashid/feature-enable-checking into 7073e25 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 98.118% when pulling 54e918d on rashid/feature-enable-checking into 7073e25 on master.

@coveralls
Copy link

coveralls commented Mar 27, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 98.118% when pulling 052ec8c on rashid/feature-enable-checking into ce6db76 on master.

@rashidsp rashidsp requested a review from a team March 28, 2019 11:19
@msohailhussain msohailhussain requested a review from a team March 29, 2019 18:22
@msohailhussain
Copy link
Contributor

@mjc1283 Can you please merge if it's OK.

@mjc1283 mjc1283 merged commit d6ed90b into master Apr 1, 2019
@mjc1283 mjc1283 deleted the rashid/feature-enable-checking branch April 1, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashidsp @coveralls @msohailhussain @mjc1283