refact: Revise ADF log more actionable #208
Merged
+72
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliabbasrizvi
approved these changes
Jul 28, 2020
| ->getMock(); | ||
|
|
||
| $mock = new MockHandler([ | ||
| new Response(307, [], '') |
There was a problem hiding this comment.
Indentation seems off.
Comment on lines
230
to
233
| ->setConstructorArgs(array(null, $this->url, null, false, DATAFILE, false, | ||
| $this->loggerMock, $this->errorHandlerMock)) | ||
| ->setMethods(array('handleResponse')) | ||
| ->getMock(); |
There was a problem hiding this comment.
Indentation seems off.
Comment on lines
247
to
248
| ->method('log') | ||
| ->with(Logger::ERROR, sprintf("Unexpected response when trying to fetch datafile, status code: 307. Please check your SDK key and/or datafile access token.")); |
There was a problem hiding this comment.
Indentation seems off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This revises a couple of logs in HttpProjectConfigManager.
Test plan
Issues