Skip to content

ci: Run source clear before linting and tests #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Jul 29, 2020

Summary

Stages run sequentially on Travis. If a stage fails, all the following stages are not executed. We execute source clear only on cron, and if due to any reason unit or integration tests fail, the source clear is not executed. Hence, moving source clear stage before tests.

Test plan

All unit tests must be passed.
FSC must be passed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oakbani oakbani requested a review from a team as a code owner July 29, 2020 11:16
@oakbani oakbani removed their assignment Jul 29, 2020
@coveralls
Copy link

coveralls commented Jul 29, 2020

Coverage Status

Coverage increased (+0.009%) to 98.222% when pulling 25cb03d on oakbani-patch-1 into efa480f on master.

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi aliabbasrizvi merged commit 33336f4 into master Jul 29, 2020
@aliabbasrizvi aliabbasrizvi deleted the oakbani-patch-1 branch July 29, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants