Skip to content

feat: Support for Sending Flag Decisions #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 16, 2020
Merged

feat: Support for Sending Flag Decisions #215

merged 8 commits into from
Oct 16, 2020

Conversation

zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Oct 5, 2020 •
edited
Loading

Summary

  1. Add experiment/feature flag key, and decision type to impression events.
  2. Send events for ALL decision types if send_flag_decisions is enabled.
  3. Add Metadata field to EventBatch.Decisions to capture flag key, rule key, rule type and variation key.

Test plan

  1. Manually Tested thoroughly.
  2. Added new unit tests.

@zashraf1985
first draft. Pending Items!
148cb9e 
1. add flag to config.
2. add unit tests.
3. Get experiment id and campaign id in case of rollout.
@coveralls
Copy link

coveralls commented Oct 5, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 98.144% when pulling caa6dc1 on zeeshan/flag-decisions into 9aef7ba on master.

@zashraf1985 zashraf1985 closed this Oct 6, 2020
@zashraf1985 zashraf1985 reopened this Oct 6, 2020
@zashraf1985 zashraf1985 closed this Oct 9, 2020
@zashraf1985 zashraf1985 reopened this Oct 9, 2020
@zashraf1985 zashraf1985 marked this pull request as ready for review October 9, 2020 00:06
@zashraf1985 zashraf1985 requested a review from a team as a code owner October 9, 2020 00:06
@zashraf1985 zashraf1985 removed their assignment Oct 9, 2020
pawels-optimizely
pawels-optimizely suggested changes Oct 9, 2020
View reviewed changes
Copy link

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can have all the things populated in metadata, and sometimes rule_key will be different from flag_key

@msohailhussain msohailhussain requested review from aliabbasrizvi and a team October 15, 2020 05:38
@zashraf1985 zashraf1985 removed their assignment Oct 16, 2020
pawels-optimizely
pawels-optimizely reviewed Oct 16, 2020
View reviewed changes
tests/EventTests/EventBuilderTest.php
'variation_id'=> '7721010009'
'variation_id'=> '7721010009',
'metadata'=> [
'flag_key' => 'test_experiment',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have a different value for rule_key and flag_key

pawels-optimizely
pawels-optimizely approved these changes Oct 16, 2020
View reviewed changes
Copy link

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit comment

@pawels-optimizely pawels-optimizely merged commit 12a0ae3 into master Oct 16, 2020
@pawels-optimizely pawels-optimizely deleted the zeeshan/flag-decisions branch October 16, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zashraf1985 @coveralls @pawels-optimizely @msohailhussain @optimizely-codereview-bot