refact: user context is cloned when passed to Decide APIs in Optimizely Class #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jae Kim <[email protected]>
…ameter (#221) * impact * fix Decision Service Tests * fix: test cases affected due to bucketer * fix: unit tests affected by reasons * fix: incompatible syntax for < php 7.0 * fix: some more tests * audience eval logs * tests: bucketer reasons * tests: Decision Service reasons * tests: decision service further * update: copyright headers
ozayr-zaviar
changed the title
oakbani
suggested changes
Jan 13, 2021
| @@ -31,24 +31,29 @@ public function __construct(Optimizely $optimizelyClient, $userId, array $attrib | |||
| $this->attributes = $attributes; | |||
| } | |||
|
|
|||
| public function clone() | |||
There was a problem hiding this comment.
let's keep this protected for now
| public function setAttribute($key, $value) | ||
| { | ||
| $this->attributes[$key] = $value; | ||
| } | ||
|
|
||
| public function decide($key, array $options = []) | ||
| { | ||
| return $this->optimizelyClient->decide($this, $key, $options); | ||
| return $this->optimizelyClient->decide($this->clone(), $key, $options); |
There was a problem hiding this comment.
Can you add a unit test that verifies that the OptimizelyUserContext object received in decide response is not the same object on which the decide was called?
oakbani
approved these changes
Jan 14, 2021
| $optUserContext = new OptimizelyUserContext($optlyObject, $userId, $attributes); | ||
| $decision = $optUserContext->decide('test_feature', ['DISABLE_DECISION_EVENT', 'ENABLED_FLAGS_ONLY']); | ||
| $optUserContext->setAttribute("test_key", "test_value"); | ||
| $this->assertNotEquals( |
There was a problem hiding this comment.
Why don't you directly compare the user context objects?
jaeopt
requested changes
Jan 14, 2021
| $this->assertNotEquals( | ||
| $optUserContext->getAttributes(), | ||
| $decision->getUserContext()->getAttributes() | ||
| ); |
There was a problem hiding this comment.
Can we also check if the returned userContext equal to the original user/attributes.
jaeopt
reviewed
Jan 14, 2021
| @@ -31,24 +31,29 @@ public function __construct(Optimizely $optimizelyClient, $userId, array $attrib | |||
| $this->attributes = $attributes; | |||
| } | |||
|
|
|||
| protected function replicate() | |||
There was a problem hiding this comment.
rename to "copy" (or "clone")? Are they reserved?
…sdk into uzair/clone-user-context
oakbani
changed the title
|
@jaeopt rebased to master and addressed comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
copy()added in user_context to clone user_context before passing it indecide,decide_for_keysanddecide_allas an argumentTest plan