Skip to content

fix(ForcedDecision): remove config-ready check from forced-decision apis #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

fix(ForcedDecision): remove config-ready check from forced-decision apis #236

merged 1 commit into from
Dec 8, 2021

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Dec 3, 2021

Summary

  • Remove config-ready check from forced-decision apis

Test plan

  • Unit and FSC tests

@mnoman09 mnoman09 requested a review from a team as a code owner December 3, 2021 12:11
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.293% when pulling d5a1efb on mnoman/removeConfigCheck into e5bfc38 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.293% when pulling d5a1efb on mnoman/removeConfigCheck into e5bfc38 on master.

@coveralls
Copy link

coveralls commented Dec 3, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 97.775% when pulling d5a1efb on mnoman/removeConfigCheck into e5bfc38 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.293% when pulling d5a1efb on mnoman/removeConfigCheck into e5bfc38 on master.

jaeopt
jaeopt approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msohailhussain msohailhussain merged commit ebfed83 into master Dec 8, 2021
@msohailhussain msohailhussain deleted the mnoman/removeConfigCheck branch December 8, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnoman09 @coveralls @jaeopt @msohailhussain @NomanShoaib