Skip to content

refac: Moves findValidatedForcedDecision method to decision service #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2022
Merged

refac: Moves findValidatedForcedDecision method to decision service #238

merged 2 commits into from
Jan 6, 2022

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Dec 22, 2021 •
edited by yasirfolio3
Loading

Summary

  • Removed getFlagVariationByKey from optimizely and using it directly from project config.
  • Moved findValidatedForcedDecision method to decision service to remove cyclic dependency.

Test plan

All unit test and FSC tests should pass.

@NomanShoaib
- removed flagVariationbyKey from optimizely class
7f8392e 
- Moves findValidatedForcedDecisin method to decision service to remove cyclic dependency
@mnoman09 mnoman09 requested a review from a team as a code owner December 22, 2021 13:31
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.292% when pulling 7f8392e on mnoman/validateForcedDecisionMove into 34e8e66 on master.

@coveralls
Copy link

coveralls commented Dec 22, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.0009%) to 97.781% when pulling c848d56 on mnoman/validateForcedDecisionMove into 34e8e66 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.292% when pulling 7f8392e on mnoman/validateForcedDecisionMove into 34e8e66 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.292% when pulling 7f8392e on mnoman/validateForcedDecisionMove into 34e8e66 on master.

yasirfolio3
yasirfolio3 approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnoman09 mnoman09 changed the title refac: Moves findValidatedForcedDecision method to decision service to remove cyclic dependency refac: Moves findValidatedForcedDecision method to decision service Dec 29, 2021
dustin-sier
dustin-sier approved these changes Dec 30, 2021
View reviewed changes
Copy link

@dustin-sier dustin-sier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeopt
jaeopt approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msohailhussain msohailhussain merged commit 00f3c3a into master Jan 6, 2022
@msohailhussain msohailhussain deleted the mnoman/validateForcedDecisionMove branch January 6, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasirfolio3 yasirfolio3 yasirfolio3 approved these changes

@jaeopt jaeopt jaeopt approved these changes

@dustin-sier dustin-sier dustin-sier approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mnoman09 @coveralls @yasirfolio3 @jaeopt @dustin-sier @msohailhussain @NomanShoaib