Skip to content

Fix #1003: Check type of artifact is 'jar' before adding it to classpath #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Jurrie
Copy link

@Jurrie Jurrie commented Feb 25, 2019

No description provided.

@graalvmbot
Copy link
Collaborator

Hello Jurrie Overgoor, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address 1213142+jurrie -(at)- users -(dot)- noreply -(dot)- github -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@Jurrie
Copy link
Author

Jurrie commented Feb 25, 2019

Hello @graalvmbot :) I've already signed the OCA. I signed and e-mailed it on the 15th of February this year.

@sanzinger
Copy link
Contributor

Hi Jurrie,

thank you for your contribution. The bot checks against the email address provided by the author in the git commit. In this case it is a generic email address from github ([email protected]), which we do not allow. Please amend the commit and change the email address provided with your OCA.

Then I can whitelist this email address for contribution.

Stefan

@Jurrie
Copy link
Author

Jurrie commented Feb 25, 2019

Hi @sanzinger,

But that's the email I wrote down on the OCA... :) There was no mention of any requrement on the email for the OCA form. Why should it be a working email address?

Jurrie

@olpaw olpaw self-requested a review February 25, 2019 13:55
@sanzinger
Copy link
Contributor

sanzinger commented Feb 25, 2019

Ok, this is fine for me. (I cannot access the form you have signed) I have started whitelisting email address [email protected]. When it is approved everything should go well.

@sanzinger
Copy link
Contributor

@Jurrie I have doublechecked with the team managing the OCA list. I am sorry but they have not received the OCA document yet. Please retry sending it to oracle-ca_us [at] oracle [dot] com as instructed here.

Stefan

@olpaw
Copy link
Member

olpaw commented Mar 1, 2019

see #1003 (comment)

@olpaw olpaw closed this Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants