Skip to content

chore: refactor provenance level 3 check into analysis #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Mar 11, 2025

Conversation

benmss
Copy link
Member

@benmss benmss commented Aug 7, 2024

This PR refactors the provenance level 3 check so that its logic takes place as part of the analysis, and the results of which are stored in the database along with the provenance itself. This check then only needs to read from the analysis context to report the results.

To better separate provenance related logic from the Repo / Commit Finder, provenance scripts are moved to a new sub module.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 7, 2024
@benmss benmss force-pushed the benmss/refactor-provenance-level-3 branch from 0618836 to 4190dab Compare August 7, 2024 07:27
@benmss benmss force-pushed the benmss/refactor-provenance-level-3 branch from 4190dab to c0e88a4 Compare August 15, 2024 03:40
@benmss benmss marked this pull request as ready for review August 15, 2024 04:57
@benmss benmss force-pushed the benmss/refactor-provenance-level-3 branch 2 times, most recently from 4eafea1 to e00f779 Compare January 14, 2025 02:46
@benmss benmss marked this pull request as draft January 16, 2025 03:55
@benmss benmss force-pushed the benmss/refactor-provenance-level-3 branch 3 times, most recently from 24a9fc8 to b4e0944 Compare January 23, 2025 07:04
@benmss benmss marked this pull request as ready for review January 27, 2025 23:47
@behnazh-w behnazh-w requested a review from nicallen February 3, 2025 03:21
@benmss benmss force-pushed the benmss/refactor-provenance-level-3 branch from 4689b11 to 2786fb3 Compare February 14, 2025 06:54
@behnazh-w
Copy link
Member

behnazh-w commented Mar 7, 2025

@benmss Please add the new verify-provenance cmd line option to the documentation (docs/source/pages/cli_usage/index.rst) and make sure the tutorials and documentation pages that require provenance verification are also updated.

@behnazh-w
Copy link
Member

For some reason the tests/integration/cases/ossf_scorecard/test.yaml and tests/integration/cases/micronaut-projects_micronaut-test/test.yaml tests, which verify the provenances, do not include --verify-provenance but still pass.

@benmss benmss force-pushed the benmss/refactor-provenance-level-3 branch from 1ad1715 to 9718aa7 Compare March 10, 2025 02:39
benmss added 22 commits March 11, 2025 14:38
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
@benmss benmss force-pushed the benmss/refactor-provenance-level-3 branch from 8178a1d to 864dfac Compare March 11, 2025 04:39
@benmss benmss merged commit 0a81f5e into staging Mar 11, 2025
9 checks passed
@benmss benmss deleted the benmss/refactor-provenance-level-3 branch April 8, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants