Migrate to OCI SDK #148
Merged
Migrate to OCI SDK #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonlord
approved these changes
Mar 19, 2018
jhorwit2
suggested changes
Mar 19, 2018
| @@ -25,16 +25,16 @@ import ( | |||
| "github.com/golang/glog" | |||
|
|
|||
| utilruntime "k8s.io/apimachinery/pkg/util/runtime" | |||
| "k8s.io/apimachinery/pkg/util/wait" | |||
| "k8s.io/client-go/informers" | |||
| wait "k8s.io/apimachinery/pkg/util/wait" | |||
There was a problem hiding this comment.
the package is already called wait so the first part is redundant.
pkg/oci/client/compute.go
Outdated
| // GetInstance gets information about the specified instance. | ||
| GetInstance(ctx context.Context, id string) (*core.Instance, error) | ||
| // GetInstanceByDisplayName gets information about the named instance. | ||
| GetInstanceByDisplayName(ctx context.Context, displayName string) (*core.Instance, error) |
There was a problem hiding this comment.
Is there any reason to ever use this over GetInstanceByNodeName?
pkg/oci/client/compute.go
Outdated
| func IsInstanceInTerminalState(instance *core.Instance) bool { | ||
| return instance.LifecycleState == core.InstanceLifecycleStateTerminated || | ||
| instance.LifecycleState == core.InstanceLifecycleStateTerminating || | ||
| instance.LifecycleState == "UNKNOWN" |
There was a problem hiding this comment.
The client removed this enum I think so i don't think we need it anymore.
| } | ||
|
|
||
| func (c *client) CreateCertificate(ctx context.Context, lbID, certificate, key string) (string, error) { | ||
| // TODO(apryde): We currently don't have a mechanism for supplying |
There was a problem hiding this comment.
Is there a ticket tracking this?
pkg/oci/client/load_balancer.go
Outdated
| wr = twr | ||
| return true, nil | ||
| case loadbalancer.WorkRequestLifecycleStateFailed: | ||
| return false, fmt.Errorf("WorkRequest %q failed: %s", id, twr.Message) |
pkg/oci/instances.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| return []api.NodeAddress{}, errors.Wrap(err, "GetInstanceByNodeName") |
There was a problem hiding this comment.
any reason you aren't returning nil anymore?
pkg/oci/load_balancer_spec.go
Outdated
| } | ||
| } | ||
| certs[s.SSLConfig.Name] = loadbalancer.CertificateDetails{ | ||
| CertificateName: common.String(s.SSLConfig.Name), |
There was a problem hiding this comment.
nit: you don't need to use these common methods. Just use &
l-technicore
pushed a commit
to l-technicore/oci-cloud-controller-manager
that referenced
this pull request
Jun 14, 2022
…m task/OKE-14472 to internal * commit '70a07d7273ef81d60464bd8bb18922e39b65a091': removed TCP health check for SSL enabled traffic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the project to use the official OCI Go SDK.
CHANGELOG
Test status
Closes: #136