Support load balancer listeners with http protocol via annotation #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydie
suggested changes
Aug 27, 2018
pkg/oci/load_balancer.go
Outdated
| @@ -70,6 +70,10 @@ const ( | |||
| // ServiceAnnotaionLoadBalancerSecurityListManagementMode is a Service annotation for | |||
| // specifying the security list managment mode ("All", "Frontend", "None") that configures how security lists are managed by the CCM | |||
| ServiceAnnotaionLoadBalancerSecurityListManagementMode = "service.beta.kubernetes.io/oci-load-balancer-security-list-management-mode" | |||
|
|
|||
| // ServiceAnnotationLoadBalancerEnableHTTPProtocol is a Service annotation for | |||
| // enabling/disabling the load balancer listener with the http protocol. | |||
There was a problem hiding this comment.
It would be nice if the comment stated what the accepted values are, and also what is the effect of setting this, i.e. why would a user want to do it/why are we supporting it?
harveylowndes
changed the title
harveylowndes
force-pushed
the
support-http-load-balancer-listeners
branch
from
ff5dd26 to
23f5a14
Compare
prydie
approved these changes
Aug 28, 2018
harveylowndes
force-pushed
the
support-http-load-balancer-listeners
branch
from
70a17aa to
0e39e7e
Compare
harveylowndes
changed the title
prydie
reviewed
Aug 29, 2018
docs/load-balancer-annotations.md
Outdated
| @@ -28,6 +28,7 @@ spec: | |||
| | `oci-load-balancer-subnet2` | The OCID of the second [subnet][2] of the two required subnets to attach the load balancer to. Must be in separate Availability Domains. | Value provided in config file | | |||
| | `oci-load-balancer-connection-idle-timeout` | The maximum idle time, in seconds, allowed between two successive receive or two successive send operations between the client and backend servers. | `300` for TCP listeners, `60` for HTTP listeners | | |||
| | `oci-load-balancer-security-list-management-mode` | Specifies the [security list mode](##security-list-management-modes) (`"All"`, `"Frontend"`,`"None"`) to configure how security lists are managed by the CCM. | `"All"` | |||
| | `oci-load-balancer-backend-protocol` | Specifies the [load balancer listener][5] backend protocol ("TCP", "HTTP"). | `"TCP"` | |||
There was a problem hiding this comment.
The linked page is too general maybe just copy from the API documentation:
Specify protocol on which the listener accepts connection requests. To get a list of valid protocols, use the ListProtocols operation.
harveylowndes
force-pushed
the
support-http-load-balancer-listeners
branch
from
0e39e7e to
0de33ae
Compare
harveylowndes
force-pushed
the
support-http-load-balancer-listeners
branch
from
0de33ae to
1d5807d
Compare
prydie
approved these changes
Aug 29, 2018
ayushverma14
pushed a commit
to ayushverma14/oci-cloud-controller-manager
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #208
Currently only TCP listeners are supported when creating a service type load balancer. The oci console allows for either TCP or HTTP.
When the service is create with the
service.beta.kubernetes.io/oci-load-balancer-backend-protocolannotation is set to"HTTP"the listener protocol will be overridden to use HTTP. The value"TCP"may also be used for TCP listeners, however, this is the default when the value is empty or when the annotation is not present.